Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

The other day I tried doing a git blame on a line of code. Since we use squash + merge for PRs, it pointed to a 1000 line commit with a message similar to:

  Refactor widget (#1234)
  
  * wip
  * wip
  * wip
  * fixes
  * pr review
I opened the old PR on Github, and all it contained was a link to the Trello card for the task, where I finally found some context and description for the changes.

It's ridiculous.



Oh man. I had a coworker once who would frequently commit with a single word commit "fixup" - often as you'd expect at the end of a PR but never squashed or put anymore detail into what they actually did, often much more than simple whitespace or linting changes you'd expect from the message, so you had to be really careful to check. If you then searched the commit history for "fixup" 100s of commits would show up. The person in question had so many other issues working in this team that this particular one was never brought up but it drove me mad.


At least it told you Refactor widget. ;p Even worse is repos where the first line of every commit message is just “Merge pull request #12345 from user/fixstuff into master.”




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: